aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2016-07-01 16:10:27 +0900
committerRyuta Kamizono <kamipo@gmail.com>2016-07-01 16:10:27 +0900
commit5d3a0b14c0439beab8e3af946dec88fddc07f896 (patch)
tree09969a55a032a695593388f82826cbba29352ef8 /activerecord/lib
parent49a881e0db1ef64fcbae2b7ddccfd5ccea26ae01 (diff)
downloadrails-5d3a0b14c0439beab8e3af946dec88fddc07f896.tar.gz
rails-5d3a0b14c0439beab8e3af946dec88fddc07f896.tar.bz2
rails-5d3a0b14c0439beab8e3af946dec88fddc07f896.zip
Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
Because causing an extra query by `sql_for_insert` for guessing a primary key. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/relation.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation.rb b/activerecord/lib/active_record/relation.rb
index 7a1552856b..93baa882ad 100644
--- a/activerecord/lib/active_record/relation.rb
+++ b/activerecord/lib/active_record/relation.rb
@@ -65,7 +65,7 @@ module ActiveRecord
@klass.connection.insert(
im,
'SQL',
- primary_key,
+ primary_key || false,
primary_key_value,
nil,
binds)