diff options
| author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2012-08-02 14:01:44 -0300 |
|---|---|---|
| committer | Santiago Pastorino <santiago@wyeworks.com> | 2012-08-02 15:39:06 -0300 |
| commit | 55e05d465df668cd057d320664a7168990b6d6fb (patch) | |
| tree | 878dbcf8385b66e38fe7803d71e576d84a5e7e8f /activerecord/lib | |
| parent | 5c42889e3b37a4f161dde548b204b47a06d7c97c (diff) | |
| download | rails-55e05d465df668cd057d320664a7168990b6d6fb.tar.gz rails-55e05d465df668cd057d320664a7168990b6d6fb.tar.bz2 rails-55e05d465df668cd057d320664a7168990b6d6fb.zip | |
Do not consider the numeric attribute as changed if the old value is
zero and the new value is not a string.
Before this commit this was the behavior
r = Review.find_by_issue(0)
r.issue
=> 0
r.changes
=> {}
r.issue = 0
=> 0
r.changed?
=> true
r.changes
=> {"issue"=>[0,0]}
Fixes #7237
Diffstat (limited to 'activerecord/lib')
| -rw-r--r-- | activerecord/lib/active_record/attribute_methods/dirty.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/attribute_methods/dirty.rb b/activerecord/lib/active_record/attribute_methods/dirty.rb index 586a189011..ed863a9696 100644 --- a/activerecord/lib/active_record/attribute_methods/dirty.rb +++ b/activerecord/lib/active_record/attribute_methods/dirty.rb @@ -104,7 +104,7 @@ module ActiveRecord def changes_from_zero_to_string?(old, value) # For columns with old 0 and value non-empty string - old == 0 && value.present? && value != '0' + old == 0 && value.is_a?(String) && value.present? && value != '0' end end end |