diff options
author | Rafael França <rafaelmfranca@gmail.com> | 2015-11-08 11:48:38 -0200 |
---|---|---|
committer | Rafael França <rafaelmfranca@gmail.com> | 2015-11-08 11:48:38 -0200 |
commit | 54c87a1676b626b62b628320f57442ae6d9c59f7 (patch) | |
tree | e4eab9384c95c45aefe223f41355a274f6bb909f /activerecord/lib | |
parent | 25673f47b607528d12b0f4d1bace30b2c41a97fa (diff) | |
parent | c8bbe9aefae3fdee1eebc8c3e95f5009f5148034 (diff) | |
download | rails-54c87a1676b626b62b628320f57442ae6d9c59f7.tar.gz rails-54c87a1676b626b62b628320f57442ae6d9c59f7.tar.bz2 rails-54c87a1676b626b62b628320f57442ae6d9c59f7.zip |
Merge pull request #22224 from kassio/master
Improve support for non Active Record objects on `validates_associated`
Diffstat (limited to 'activerecord/lib')
-rw-r--r-- | activerecord/lib/active_record/validations/associated.rb | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/validations/associated.rb b/activerecord/lib/active_record/validations/associated.rb index 32fbaf0a91..b14db85167 100644 --- a/activerecord/lib/active_record/validations/associated.rb +++ b/activerecord/lib/active_record/validations/associated.rb @@ -2,10 +2,16 @@ module ActiveRecord module Validations class AssociatedValidator < ActiveModel::EachValidator #:nodoc: def validate_each(record, attribute, value) - if Array.wrap(value).reject {|r| r.marked_for_destruction? || r.valid?}.any? - record.errors.add(attribute, :invalid, options.merge(:value => value)) + if Array(value).reject { |r| valid_object?(r) }.any? + record.errors.add(attribute, :invalid, options.merge(value: value)) end end + + private + + def valid_object?(record) + (record.respond_to?(:marked_for_destruction?) && record.marked_for_destruction?) || record.valid? + end end module ClassMethods |