aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2014-10-31 08:38:40 -0600
committerSean Griffin <sean@thoughtbot.com>2014-10-31 08:40:16 -0600
commit53ec0bc0551c696add0a5ffff506fc9e83065bc0 (patch)
tree248907595958e68d301557af691e890c3ee2d821 /activerecord/lib
parent828c64241c34668bb540019cd71e232400335e74 (diff)
downloadrails-53ec0bc0551c696add0a5ffff506fc9e83065bc0.tar.gz
rails-53ec0bc0551c696add0a5ffff506fc9e83065bc0.tar.bz2
rails-53ec0bc0551c696add0a5ffff506fc9e83065bc0.zip
Don't require calculations to be aliased to a column
Arel has changed so that `.sum` no longer aliases `SUM(the_column)` to `sum_id`. This means the type returned by the adapter will be at the key `"SUM(the_column)"`. Longer term, we should eventually be able to retain type information from the AR::Base subclasses used in joined queries
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/relation/calculations.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
index eaaa409636..e20cc0e76d 100644
--- a/activerecord/lib/active_record/relation/calculations.rb
+++ b/activerecord/lib/active_record/relation/calculations.rb
@@ -253,7 +253,7 @@ module ActiveRecord
select_value = operation_over_aggregate_column(column, operation, distinct)
- column_alias = select_value.alias
+ column_alias = select_value.alias || select_value.to_sql
relation.select_values = [select_value]
query_builder = relation.arel