aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorSean Griffin <sean@seantheprogrammer.com>2014-12-11 13:25:22 -0700
committerSean Griffin <sean@seantheprogrammer.com>2014-12-11 13:25:22 -0700
commit387065a023b3883576a581af79b0a202bdcc07a8 (patch)
tree629ef553db01f2e074a4375408dae26868923d20 /activerecord/lib
parentaec7ee479ce99b7174ac34a5d203c6d91376ac89 (diff)
parentbd0d47eed6d88184cd9209b12f853f06b15de48a (diff)
downloadrails-387065a023b3883576a581af79b0a202bdcc07a8.tar.gz
rails-387065a023b3883576a581af79b0a202bdcc07a8.tar.bz2
rails-387065a023b3883576a581af79b0a202bdcc07a8.zip
Merge pull request #17994 from mfazekas/pluck-bind-values-master
Fix ProtocolViolation/bind message for polymorphic + pluck or group+calc
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/relation/calculations.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
index c8ebb41131..71673324eb 100644
--- a/activerecord/lib/active_record/relation/calculations.rb
+++ b/activerecord/lib/active_record/relation/calculations.rb
@@ -177,7 +177,7 @@ module ActiveRecord
relation.select_values = column_names.map { |cn|
columns_hash.key?(cn) ? arel_table[cn] : cn
}
- result = klass.connection.select_all(relation.arel, nil, bind_values)
+ result = klass.connection.select_all(relation.arel, nil, relation.arel.bind_values + bind_values)
result.cast_values(klass.column_types)
end
end
@@ -317,7 +317,7 @@ module ActiveRecord
relation.group_values = group
relation.select_values = select_values
- calculated_data = @klass.connection.select_all(relation, nil, bind_values)
+ calculated_data = @klass.connection.select_all(relation, nil, relation.arel.bind_values + bind_values)
if association
key_ids = calculated_data.collect { |row| row[group_aliases.first] }