aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorMarcel Molina <marcel@vernix.org>2006-01-22 09:34:41 +0000
committerMarcel Molina <marcel@vernix.org>2006-01-22 09:34:41 +0000
commit297618bddc59cdc4aaca76711874b774f9838afe (patch)
tree0f7384d0dd89444b3b2f9ae9419b44925a9cee5d /activerecord/lib
parent8d4d88a4f01ed7b569b62489654f585434beea3a (diff)
downloadrails-297618bddc59cdc4aaca76711874b774f9838afe.tar.gz
rails-297618bddc59cdc4aaca76711874b774f9838afe.tar.bz2
rails-297618bddc59cdc4aaca76711874b774f9838afe.zip
Make dynamic finders honor additional passed in :conditions. Closes #3569.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'activerecord/lib')
-rwxr-xr-xactiverecord/lib/active_record/base.rb11
1 files changed, 9 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb
index bfd9daf803..d05e3c6cae 100755
--- a/activerecord/lib/active_record/base.rb
+++ b/activerecord/lib/active_record/base.rb
@@ -990,8 +990,15 @@ module ActiveRecord #:nodoc:
conditions = construct_conditions_from_arguments(attribute_names, arguments)
- if arguments[attribute_names.length].is_a?(Hash)
- find(finder, { :conditions => conditions }.update(arguments[attribute_names.length]))
+ if (extra_options = arguments[attribute_names.size]).is_a?(Hash)
+ finder_options = extra_options.merge(:conditions => conditions)
+ if extra_options[:conditions]
+ with_scope(:find => {:conditions => extra_options[:conditions]}) do
+ find(finder, finder_options)
+ end
+ else
+ find(finder, finder_options)
+ end
else
send("find_#{finder}", conditions, *arguments[attribute_names.length..-1]) # deprecated API
end