diff options
| author | Roque Pinel <repinel@gmail.com> | 2015-07-19 22:00:36 -0400 |
|---|---|---|
| committer | Sean Griffin <sean@thoughtbot.com> | 2015-07-20 09:12:01 -0600 |
| commit | 12b0b26df7560ab5199ba830586864085441508f (patch) | |
| tree | fc2cc53a6795ee099fec878e4c33f7337f05b476 /activerecord/lib | |
| parent | c0ef95a1c6db3095c4b5f80f8044fbbbdfebeff1 (diff) | |
| download | rails-12b0b26df7560ab5199ba830586864085441508f.tar.gz rails-12b0b26df7560ab5199ba830586864085441508f.tar.bz2 rails-12b0b26df7560ab5199ba830586864085441508f.zip | |
Fix state being carried over from previous transaction
This clears the transaction record state when the transaction finishes
with a `:committed` status.
Considering the following example where `name` is a required attribute.
Before we had `new_record?` returning `true` for a persisted record:
```ruby
author = Author.create! name: 'foo'
author.name = nil
author.save # => false
author.new_record? # => true
```
Diffstat (limited to 'activerecord/lib')
| -rw-r--r-- | activerecord/lib/active_record/transactions.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/activerecord/lib/active_record/transactions.rb b/activerecord/lib/active_record/transactions.rb index 267ac26c79..887d7a5903 100644 --- a/activerecord/lib/active_record/transactions.rb +++ b/activerecord/lib/active_record/transactions.rb @@ -379,6 +379,10 @@ module ActiveRecord raise ActiveRecord::Rollback unless status end status + ensure + if @transaction_state && @transaction_state.committed? + clear_transaction_record_state + end end protected |