Merge pull request #35838 from yahonda/more_than_1000_inlist

Address `ORA-01795: maximum number of expressions in a list is 1000`

2 files changed, 96 insertions, 0 deletions

diff --git a/activerecord/lib/arel/visitors/oracle.rb b/activerecord/lib/arel/visitors/oracle.rb
index f96bf65ee5..500974dff5 100644
--- a/activerecord/lib/arel/visitors/oracle.rb
+++ b/activerecord/lib/arel/visitors/oracle.rb
@@ -87,6 +87,50 @@ module Arel # :nodoc: all
           collector << " )"
         end
 
+        def visit_Arel_Nodes_In(o, collector)
+          if Array === o.right && !o.right.empty?
+            o.right.delete_if { |value| unboundable?(value) }
+          end
+
+          if Array === o.right && o.right.empty?
+            collector << "1=0"
+          else
+            first = true
+            o.right.each_slice(in_clause_length) do |sliced_o_right|
+              collector << " OR " unless first
+              first = false
+
+              collector = visit o.left, collector
+              collector << " IN ("
+              visit(sliced_o_right, collector)
+              collector << ")"
+            end
+          end
+          collector
+        end
+
+        def visit_Arel_Nodes_NotIn(o, collector)
+          if Array === o.right && !o.right.empty?
+            o.right.delete_if { |value| unboundable?(value) }
+          end
+
+          if Array === o.right && o.right.empty?
+            collector << "1=1"
+          else
+            first = true
+            o.right.each_slice(in_clause_length) do |sliced_o_right|
+              collector << " AND " unless first
+              first = false
+
+              collector = visit o.left, collector
+              collector << " NOT IN ("
+              visit(sliced_o_right, collector)
+              collector << ")"
+            end
+          end
+          collector
+        end
+
         def visit_Arel_Nodes_UpdateStatement(o, collector)
           # Oracle does not allow ORDER BY/LIMIT in UPDATEs.
           if o.orders.any? && o.limit.nil?
@@ -154,6 +198,10 @@ module Arel # :nodoc: all
           collector = visit [o.left, o.right, 0, 1], collector
           collector << ")"
         end
+
+        def in_clause_length
+          1000
+        end
     end
   end
 end
diff --git a/activerecord/lib/arel/visitors/oracle12.rb b/activerecord/lib/arel/visitors/oracle12.rb
index 9a7fe4d626..8e0f07fca9 100644
--- a/activerecord/lib/arel/visitors/oracle12.rb
+++ b/activerecord/lib/arel/visitors/oracle12.rb
@@ -41,6 +41,50 @@ module Arel # :nodoc: all
           collector << " )"
         end
 
+        def visit_Arel_Nodes_In(o, collector)
+          if Array === o.right && !o.right.empty?
+            o.right.delete_if { |value| unboundable?(value) }
+          end
+
+          if Array === o.right && o.right.empty?
+            collector << "1=0"
+          else
+            first = true
+            o.right.each_slice(in_clause_length) do |sliced_o_right|
+              collector << " OR " unless first
+              first = false
+
+              collector = visit o.left, collector
+              collector << " IN ("
+              visit(sliced_o_right, collector)
+              collector << ")"
+            end
+          end
+          collector
+        end
+
+        def visit_Arel_Nodes_NotIn(o, collector)
+          if Array === o.right && !o.right.empty?
+            o.right.delete_if { |value| unboundable?(value) }
+          end
+
+          if Array === o.right && o.right.empty?
+            collector << "1=1"
+          else
+            first = true
+            o.right.each_slice(in_clause_length) do |sliced_o_right|
+              collector << " AND " unless first
+              first = false
+
+              collector = visit o.left, collector
+              collector << " NOT IN ("
+              visit(sliced_o_right, collector)
+              collector << ")"
+            end
+          end
+          collector
+        end
+
         def visit_Arel_Nodes_UpdateStatement(o, collector)
           # Oracle does not allow ORDER BY/LIMIT in UPDATEs.
           if o.orders.any? && o.limit.nil?
@@ -62,6 +106,10 @@ module Arel # :nodoc: all
           collector = visit [o.left, o.right, 0, 1], collector
           collector << ")"
         end
+
+        def in_clause_length
+          1000
+        end
     end
   end
 end