diff options
| author | Akira Matsuda <ronnie@dio.jp> | 2019-07-27 12:56:39 +0900 |
|---|---|---|
| committer | Akira Matsuda <ronnie@dio.jp> | 2019-07-27 13:06:49 +0900 |
| commit | d1ffe59ab5fd6e811833c127d43b32e87b5d7131 (patch) | |
| tree | c866689e6b51b1f7eac9e49212d2938d56f6ecb2 /activerecord/lib/arel | |
| parent | e9651deea4145f62224af56af027bfbb3e45e4cd (diff) | |
| download | rails-d1ffe59ab5fd6e811833c127d43b32e87b5d7131.tar.gz rails-d1ffe59ab5fd6e811833c127d43b32e87b5d7131.tar.bz2 rails-d1ffe59ab5fd6e811833c127d43b32e87b5d7131.zip | |
Use match? where we don't need MatchData
We're already running Performance/RegexpMatch cop, but it seems like the cop is not always =~ justice
Diffstat (limited to 'activerecord/lib/arel')
| -rw-r--r-- | activerecord/lib/arel/visitors/oracle.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/arel/visitors/oracle.rb b/activerecord/lib/arel/visitors/oracle.rb index aab66301ef..c54aec71a6 100644 --- a/activerecord/lib/arel/visitors/oracle.rb +++ b/activerecord/lib/arel/visitors/oracle.rb @@ -9,7 +9,7 @@ module Arel # :nodoc: all # if need to select first records without ORDER BY and GROUP BY and without DISTINCT # then can use simple ROWNUM in WHERE clause - if o.limit && o.orders.empty? && o.cores.first.groups.empty? && !o.offset && o.cores.first.set_quantifier.class.to_s !~ /Distinct/ + if o.limit && o.orders.empty? && o.cores.first.groups.empty? && !o.offset && !o.cores.first.set_quantifier.class.to_s.match?(/Distinct/) o.cores.last.wheres.push Nodes::LessThanOrEqual.new( Nodes::SqlLiteral.new("ROWNUM"), o.limit.expr ) |