diff options
author | Jon Leighton <j@jonathanleighton.com> | 2012-11-09 05:42:04 -0800 |
---|---|---|
committer | Jon Leighton <j@jonathanleighton.com> | 2012-11-09 05:42:04 -0800 |
commit | dbb39e53414294818c056f1db336471dd347d413 (patch) | |
tree | eaa22d1547eeb953a532e53dffe698780dfc42ab /activerecord/lib/active_record | |
parent | edd94cee9af1688dd036fc58fd405adb30a5e0da (diff) | |
parent | 710e3710813e52ce71ee2cd5a754cf6462b2ecd3 (diff) | |
download | rails-dbb39e53414294818c056f1db336471dd347d413.tar.gz rails-dbb39e53414294818c056f1db336471dd347d413.tar.bz2 rails-dbb39e53414294818c056f1db336471dd347d413.zip |
Merge pull request #8116 from senny/7993_configure_counter_cache_for_has_many
:counter_cache option for to support custom named counter caches
Diffstat (limited to 'activerecord/lib/active_record')
3 files changed, 5 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/associations.rb b/activerecord/lib/active_record/associations.rb index a86e43664e..5949269f2a 100644 --- a/activerecord/lib/active_record/associations.rb +++ b/activerecord/lib/active_record/associations.rb @@ -1125,6 +1125,9 @@ module ActiveRecord # If using with the <tt>:through</tt> option, the association on the join model must be # a +belongs_to+, and the records which get deleted are the join records, rather than # the associated records. + # [:counter_cache] + # This option can be used to configure a custom named <tt>:counter_cache.</tt> You only need this option, + # when you customized the name of your <tt>:counter_cache</tt> on the <tt>belongs_to</tt> association. # [:as] # Specifies a polymorphic interface (See <tt>belongs_to</tt>). # [:through] diff --git a/activerecord/lib/active_record/associations/builder/has_many.rb b/activerecord/lib/active_record/associations/builder/has_many.rb index ab8225460a..0d1bdd21ee 100644 --- a/activerecord/lib/active_record/associations/builder/has_many.rb +++ b/activerecord/lib/active_record/associations/builder/has_many.rb @@ -5,7 +5,7 @@ module ActiveRecord::Associations::Builder end def valid_options - super + [:primary_key, :dependent, :as, :through, :source, :source_type, :inverse_of] + super + [:primary_key, :dependent, :as, :through, :source, :source_type, :inverse_of, :counter_cache] end def valid_dependent_options diff --git a/activerecord/lib/active_record/associations/has_many_association.rb b/activerecord/lib/active_record/associations/has_many_association.rb index 74864d271f..f59565ae77 100644 --- a/activerecord/lib/active_record/associations/has_many_association.rb +++ b/activerecord/lib/active_record/associations/has_many_association.rb @@ -76,7 +76,7 @@ module ActiveRecord end def cached_counter_attribute_name(reflection = reflection) - "#{reflection.name}_count" + options[:counter_cache] || "#{reflection.name}_count" end def update_counter(difference, reflection = reflection) |