aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
diff options
context:
space:
mode:
authorBogdan Gusiev <agresso@gmail.com>2013-12-04 16:16:11 +0200
committerBogdan Gusiev <agresso@gmail.com>2013-12-04 16:16:11 +0200
commit998ba0e7084345a045d49a64ee9cf9d2d2441780 (patch)
treeda21b1253cccc132c2cd45cb9657fff3c24c21ee /activerecord/lib/active_record
parentb6f189e2f0bcc8f36f52c83e8ac2255d5e578a42 (diff)
downloadrails-998ba0e7084345a045d49a64ee9cf9d2d2441780.tar.gz
rails-998ba0e7084345a045d49a64ee9cf9d2d2441780.tar.bz2
rails-998ba0e7084345a045d49a64ee9cf9d2d2441780.zip
Fix bugs with changed attributes tracking when transaction gets rollback
Diffstat (limited to 'activerecord/lib/active_record')
-rw-r--r--activerecord/lib/active_record/core.rb1
-rw-r--r--activerecord/lib/active_record/transactions.rb6
2 files changed, 6 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/core.rb b/activerecord/lib/active_record/core.rb
index 8808ad5a4c..a753ad7cb1 100644
--- a/activerecord/lib/active_record/core.rb
+++ b/activerecord/lib/active_record/core.rb
@@ -428,7 +428,6 @@ module ActiveRecord
@destroyed_by_association = nil
@new_record = true
@txn = nil
- @_start_transaction_state = {}
@transaction_state = nil
@reflects_state = [false]
end
diff --git a/activerecord/lib/active_record/transactions.rb b/activerecord/lib/active_record/transactions.rb
index 45313b5e75..8eafc05fdf 100644
--- a/activerecord/lib/active_record/transactions.rb
+++ b/activerecord/lib/active_record/transactions.rb
@@ -341,6 +341,7 @@ module ActiveRecord
# Save the new record state and id of a record so it can be restored later if a transaction fails.
def remember_transaction_record_state #:nodoc:
+ @_start_transaction_state ||= {}
@_start_transaction_state[:id] = id if has_attribute?(self.class.primary_key)
unless @_start_transaction_state.include?(:new_record)
@_start_transaction_state[:new_record] = @new_record
@@ -350,6 +351,8 @@ module ActiveRecord
end
@_start_transaction_state[:level] = (@_start_transaction_state[:level] || 0) + 1
@_start_transaction_state[:frozen?] = @attributes.frozen?
+ @_start_transaction_state[:changed_attributes] ||= changed_attributes
+ @_start_transaction_state
end
# Clear the new record state and id of a record.
@@ -368,6 +371,9 @@ module ActiveRecord
@attributes = @attributes.dup if @attributes.frozen?
@new_record = restore_state[:new_record]
@destroyed = restore_state[:destroyed]
+ changed_attributes.replace(restore_state[:changed_attributes]).delete_if do |attribute, old_value|
+ old_value == @attributes[attribute]
+ end
if restore_state.has_key?(:id)
self.id = restore_state[:id]
else