aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
diff options
context:
space:
mode:
authoreileencodes <eileencodes@gmail.com>2017-08-01 13:02:53 -0400
committereileencodes <eileencodes@gmail.com>2017-08-01 13:28:57 -0400
commit92209356c310caabda8665d6369d3b1e4a1800d1 (patch)
tree58f91bdfba733804b53a64ebfbd5770af35f68c8 /activerecord/lib/active_record
parent030c66a51faf9f43bfc6093ed6cc119e9a09a09a (diff)
downloadrails-92209356c310caabda8665d6369d3b1e4a1800d1.tar.gz
rails-92209356c310caabda8665d6369d3b1e4a1800d1.tar.bz2
rails-92209356c310caabda8665d6369d3b1e4a1800d1.zip
Path parameters should default to UTF8
This commit changes the behavior such the path_params now default to UTF8 just like regular parameters. This also changes the behavior such that if a path parameter contains invalid UTF8 it returns a 400 bad request. Previously the behavior was to encode the path params as binary but that's not the same as query params. So this commit makes path params behave the same as query params. It's important to test with a path that's encoded as binary because that's how paths are encoded from the socket. The test that was altered was changed to make the behavior for bad encoding the same as query params. We want to treat path params the same as query params. The params in the test are invalid UTF8 so they should return a bad request. Fixes #29669 *Eileen M. Uchitelle, Aaron Patterson, & Tsukuru Tanimichi*
Diffstat (limited to 'activerecord/lib/active_record')
0 files changed, 0 insertions, 0 deletions