diff options
| author | lulalala <mark@goodlife.tw> | 2012-10-02 22:30:06 +0800 |
|---|---|---|
| committer | lulalala <mark@goodlife.tw> | 2012-10-02 23:49:32 +0800 |
| commit | 6e56a03f834202af4e57c50a71cc74ea08303bfd (patch) | |
| tree | e3d60012629b06078cbda72e5f1d0130a01900bc /activerecord/lib/active_record | |
| parent | 8ea88c3b74a20b56d39ab820244e0b3806a84169 (diff) | |
| download | rails-6e56a03f834202af4e57c50a71cc74ea08303bfd.tar.gz rails-6e56a03f834202af4e57c50a71cc74ea08303bfd.tar.bz2 rails-6e56a03f834202af4e57c50a71cc74ea08303bfd.zip | |
Fix reset_counters() crashing on has_many :through associations.
The counter column name in the intermediate model need to be access
via the through reflection.
Diffstat (limited to 'activerecord/lib/active_record')
| -rw-r--r-- | activerecord/lib/active_record/counter_cache.rb | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/counter_cache.rb b/activerecord/lib/active_record/counter_cache.rb index c877079b25..d28cd560d9 100644 --- a/activerecord/lib/active_record/counter_cache.rb +++ b/activerecord/lib/active_record/counter_cache.rb @@ -22,8 +22,13 @@ module ActiveRecord counters.each do |association| has_many_association = reflect_on_association(association.to_sym) - foreign_key = has_many_association.foreign_key.to_s - child_class = has_many_association.klass + if has_many_association.is_a? ActiveRecord::Reflection::ThroughReflection + foreign_key = has_many_association.through_reflection.foreign_key.to_s + child_class = has_many_association.through_reflection.klass + else + foreign_key = has_many_association.foreign_key.to_s + child_class = has_many_association.klass + end belongs_to = child_class.reflect_on_all_associations(:belongs_to) reflection = belongs_to.find { |e| e.foreign_key.to_s == foreign_key && e.options[:counter_cache].present? } counter_name = reflection.counter_cache_column |