aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2015-01-28 09:36:42 -0700
committerSean Griffin <sean@thoughtbot.com>2015-01-28 09:53:38 -0700
commit56a3d5ec9183a9bcbf140d4102d45e3928f2617a (patch)
treee83642e06544893dd8747d6f5dad2847ed4ee741 /activerecord/lib/active_record
parent58047ebdf3da86a8ed17cb269c5d4d944d1c2d88 (diff)
downloadrails-56a3d5ec9183a9bcbf140d4102d45e3928f2617a.tar.gz
rails-56a3d5ec9183a9bcbf140d4102d45e3928f2617a.tar.bz2
rails-56a3d5ec9183a9bcbf140d4102d45e3928f2617a.zip
Don't redefine autosave association callbacks in nested attrs
These callbacks will already have been defined when the association was built. The check against `reflection.autosave` happens at call time, not at define time, so simply modifying the reflection is sufficient. Fixes #18704
Diffstat (limited to 'activerecord/lib/active_record')
-rw-r--r--activerecord/lib/active_record/nested_attributes.rb1
1 files changed, 0 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/nested_attributes.rb b/activerecord/lib/active_record/nested_attributes.rb
index 846e1162a9..919bbfa649 100644
--- a/activerecord/lib/active_record/nested_attributes.rb
+++ b/activerecord/lib/active_record/nested_attributes.rb
@@ -312,7 +312,6 @@ module ActiveRecord
attr_names.each do |association_name|
if reflection = _reflect_on_association(association_name)
reflection.autosave = true
- add_autosave_association_callbacks(reflection)
nested_attributes_options = self.nested_attributes_options.dup
nested_attributes_options[association_name.to_sym] = options