diff options
author | Roque Pinel <repinel@gmail.com> | 2015-06-15 23:16:39 -0400 |
---|---|---|
committer | Roque Pinel <repinel@gmail.com> | 2015-09-11 14:29:06 -0400 |
commit | 2acec4657752d441ab87b9f5862d7918843d6409 (patch) | |
tree | 8c838ca318721dd615165b498e1bd74bd17cc1cf /activerecord/lib/active_record | |
parent | bbf0d35bf6148752911c1da4b7449450faea8755 (diff) | |
download | rails-2acec4657752d441ab87b9f5862d7918843d6409.tar.gz rails-2acec4657752d441ab87b9f5862d7918843d6409.tar.bz2 rails-2acec4657752d441ab87b9f5862d7918843d6409.zip |
Allow fixtures YAML files to set the model class in the file itself
Currently, `set_fixture_class` is only available using the
`TestFixtures` concern and it is ignored for `rake db:fixtures:load`.
Using the correct model class, it is possible for the fixture load
to also load the associations from the YAML files (e.g., `:belongs_to`
and `:has_many`).
Diffstat (limited to 'activerecord/lib/active_record')
-rw-r--r-- | activerecord/lib/active_record/fixture_set/file.rb | 15 | ||||
-rw-r--r-- | activerecord/lib/active_record/fixtures.rb | 42 |
2 files changed, 46 insertions, 11 deletions
diff --git a/activerecord/lib/active_record/fixture_set/file.rb b/activerecord/lib/active_record/fixture_set/file.rb index 8132310c91..9b74ed0ef7 100644 --- a/activerecord/lib/active_record/fixture_set/file.rb +++ b/activerecord/lib/active_record/fixture_set/file.rb @@ -18,23 +18,34 @@ module ActiveRecord def initialize(file) @file = file @rows = nil + @raw_rows = nil + @model_class = nil end def each(&block) rows.each(&block) end + def model_class + return @model_class if @model_class + row = raw_rows.find { |fixture_name, _| fixture_name == '_fixture' } + @model_class = row.last['model_class'] if row + end private def rows - return @rows if @rows + @rows ||= raw_rows.reject { |fixture_name, _| fixture_name == '_fixture' } + end + + def raw_rows + return @raw_rows if @raw_rows begin data = YAML.load(render(IO.read(@file))) rescue ArgumentError, Psych::SyntaxError => error raise Fixture::FormatError, "a YAML error occurred parsing #{@file}. Please note that YAML must be consistently indented using spaces. Tabs are not allowed. Please have a look at http://www.yaml.org/faq.html\nThe exact error was:\n #{error.class}: #{error}", error.backtrace end - @rows = data ? validate(data).to_a : [] + @raw_rows = data ? validate(data).to_a : [] end def render(content) diff --git a/activerecord/lib/active_record/fixtures.rb b/activerecord/lib/active_record/fixtures.rb index f1dc56df63..e5d51fc5fb 100644 --- a/activerecord/lib/active_record/fixtures.rb +++ b/activerecord/lib/active_record/fixtures.rb @@ -395,6 +395,23 @@ module ActiveRecord # <<: *DEFAULTS # # Any fixture labeled "DEFAULTS" is safely ignored. + # + # == Support to custom model class + # + # You can also set the model class in your fixtures YAML file. + # This is helpful when fixtures are being loaded outside tests and + # you cannot use +set_fixture_class+, e.g., when running + # <tt>rake db:fixtures:load</tt>. + # + # To load the fixtures file +test/fixtures/accounts.yml+ as the +User+ + # model, use: + # + # _fixture: + # model_class: User + # david: + # name: David + # + # Any fixture labeled "_fixture" is safely ignored. class FixtureSet #-- # An instance of FixtureSet is normally stored in a single YAML file and @@ -578,21 +595,16 @@ module ActiveRecord @name = name @path = path @config = config - @model_class = nil - if class_name.is_a?(Class) # TODO: Should be an AR::Base type class, or any? - @model_class = class_name - else - @model_class = class_name.safe_constantize if class_name - end + self.model_class = class_name + + @fixtures = read_fixture_files(path) @connection = connection @table_name = ( model_class.respond_to?(:table_name) ? model_class.table_name : self.class.default_fixture_table_name(name, config) ) - - @fixtures = read_fixture_files path, @model_class end def [](x) @@ -761,13 +773,25 @@ module ActiveRecord @column_names ||= @connection.columns(@table_name).collect(&:name) end - def read_fixture_files(path, model_class) + def model_class=(class_name) + if class_name.is_a?(Class) # TODO: Should be an AR::Base type class, or any? + @model_class = class_name + else + @model_class = class_name.safe_constantize if class_name + end + end + + # Loads the fixtures from the YAML file at +path+. + # If the file sets the +model_class+ and current instance value is not set, + # it uses the file value. + def read_fixture_files(path) yaml_files = Dir["#{path}/{**,*}/*.yml"].select { |f| ::File.file?(f) } + [yaml_file_path(path)] yaml_files.each_with_object({}) do |file, fixtures| FixtureSet::File.open(file) do |fh| + self.model_class ||= fh.model_class if fh.model_class fh.each do |fixture_name, row| fixtures[fixture_name] = ActiveRecord::Fixture.new(row, model_class) end |