diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2019-05-03 13:36:44 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2019-05-07 02:19:57 +0900 |
| commit | 718a32ca745672a977a0d4ae401f61f439767405 (patch) | |
| tree | 048ba67fc584728771525b5d273b5695f13f2ea4 /activerecord/lib/active_record/touch_later.rb | |
| parent | 020856c328085ffe4728afdab99e9008cc86d9e6 (diff) | |
| download | rails-718a32ca745672a977a0d4ae401f61f439767405.tar.gz rails-718a32ca745672a977a0d4ae401f61f439767405.tar.bz2 rails-718a32ca745672a977a0d4ae401f61f439767405.zip | |
Should attempt `committed!`/`rolledback!` to all enrolled records in the transaction
Currently, `committed!`/`rolledback!` will only be attempted for the
first enrolled record in the transaction, that will cause some
problematic behaviors.
The first one problem, `clear_transaction_record_state` won't be called
even if the transaction is finalized except the first enrolled record.
This means that de-duplicated records in the transaction won't refer
latest state (e.g. won't happen rolling back record state).
The second one problem, the enrolled order is not always the same as the
order in which the actions actually happened, the first enrolled record
may succeed no actions (e.g. `destroy` has already succeeded on another
record during `before_destroy`), it will lose to fire any transactional
callbacks.
To avoid both problems, we should attempt `committed!`/`rolledback!` to
all enrolled records in the transaction.
Diffstat (limited to 'activerecord/lib/active_record/touch_later.rb')
| -rw-r--r-- | activerecord/lib/active_record/touch_later.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/activerecord/lib/active_record/touch_later.rb b/activerecord/lib/active_record/touch_later.rb index b60cc96165..6872b7844e 100644 --- a/activerecord/lib/active_record/touch_later.rb +++ b/activerecord/lib/active_record/touch_later.rb @@ -18,6 +18,7 @@ module ActiveRecord surreptitiously_touch @_defer_touch_attrs add_to_transaction + @_new_record_before_last_commit ||= false # touch the parents as we are not calling the after_save callbacks self.class.reflect_on_all_associations(:belongs_to).each do |r| |