aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/tasks
diff options
context:
space:
mode:
authorSean Griffin <sean@seantheprogrammer.com>2016-03-24 14:54:02 -0600
committerSean Griffin <sean@seantheprogrammer.com>2016-03-24 14:58:23 -0600
commitba06dab5451cdce9c2264abd6c9dd20cb2722c8d (patch)
tree75bd8d2c153462db7a845c57dbaa31423701ba18 /activerecord/lib/active_record/tasks
parent133befb59b8389cb483fd4194acdcddc5e288ab4 (diff)
downloadrails-ba06dab5451cdce9c2264abd6c9dd20cb2722c8d.tar.gz
rails-ba06dab5451cdce9c2264abd6c9dd20cb2722c8d.tar.bz2
rails-ba06dab5451cdce9c2264abd6c9dd20cb2722c8d.zip
Memoize user provided defaults before type casting
When a proc is given as a default value, the form builder ends up displaying `Proc#to_s` when the default is used. That's because we didn't handle the proc until type casting. This issue technically can occur any time that a proc is the value before type casting, but in reality the only place that will occur is when a proc default is provided through the attributes API, so the best place to handle this edge case is there. I've opted to memoize instead of just moving the `Proc#call` up, as this made me realize that it could potentially interact very poorly with dirty checking. The code here is a little redundant, but I don't want to rely on how `value_before_type_cast` is implemented in the super class, even if it's just an `attr_reader`. Fixes #24249 Close #24306
Diffstat (limited to 'activerecord/lib/active_record/tasks')
0 files changed, 0 insertions, 0 deletions