aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/scoping
diff options
context:
space:
mode:
authorutilum <oz@utilum.com>2019-02-01 00:46:11 +0100
committerutilum <oz@utilum.com>2019-02-13 02:11:21 +0100
commit87a5379b422d38ea8766af1537593af44b6dffc6 (patch)
treef77e757600a1ef91ab5a21cfa955036ece8c1fb6 /activerecord/lib/active_record/scoping
parent8d9d46fdae4502b8881eca641c51a64ee7804194 (diff)
downloadrails-87a5379b422d38ea8766af1537593af44b6dffc6.tar.gz
rails-87a5379b422d38ea8766af1537593af44b6dffc6.tar.bz2
rails-87a5379b422d38ea8766af1537593af44b6dffc6.zip
Ruby 2.7 warning: creating a Proc without a block
As of [Revision 66772]( https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) `Proc.new` without giving a block emits `warning: tried to create Proc object without a block`. This commit fixes cases where Rails test suit tickles this warning. See CI logs: https://travis-ci.org/rails/rails/jobs/487205819#L1161-L1190 https://travis-ci.org/rails/rails/jobs/487205821#L1154-1159 https://travis-ci.org/rails/rails/jobs/487205821#L1160-L1169 https://travis-ci.org/rails/rails/jobs/487205821#L1189 https://travis-ci.org/rails/rails/jobs/487254404#L1307-L1416 https://travis-ci.org/rails/rails/jobs/487254405#L1174-L1191
Diffstat (limited to 'activerecord/lib/active_record/scoping')
-rw-r--r--activerecord/lib/active_record/scoping/default.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/scoping/default.rb b/activerecord/lib/active_record/scoping/default.rb
index 8c612df27a..6299c73dfc 100644
--- a/activerecord/lib/active_record/scoping/default.rb
+++ b/activerecord/lib/active_record/scoping/default.rb
@@ -86,8 +86,8 @@ module ActiveRecord
# # Should return a scope, you can call 'super' here etc.
# end
# end
- def default_scope(scope = nil) # :doc:
- scope = Proc.new if block_given?
+ def default_scope(scope = nil, &block) # :doc:
+ scope = block if block_given?
if scope.is_a?(Relation) || !scope.respond_to?(:call)
raise ArgumentError,