aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/schema_dumper.rb
diff options
context:
space:
mode:
authorRafael França <rafaelmfranca@gmail.com>2016-10-10 14:12:55 -0300
committerGitHub <noreply@github.com>2016-10-10 14:12:55 -0300
commit15fa282148c3fef064e9cee6564f60ea32f6a2d5 (patch)
tree1f15e7147a961f64f8e161029572af4f34bd81f7 /activerecord/lib/active_record/schema_dumper.rb
parent4d93d381e0e2eb30c7e12a0b88fdfb88ec37f399 (diff)
parent24a1a6a844120dae7e5b304932b677e5e6fcb790 (diff)
downloadrails-15fa282148c3fef064e9cee6564f60ea32f6a2d5.tar.gz
rails-15fa282148c3fef064e9cee6564f60ea32f6a2d5.tar.bz2
rails-15fa282148c3fef064e9cee6564f60ea32f6a2d5.zip
Merge pull request #26747 from kamipo/name_is_not_column_option
`name` is not a column option
Diffstat (limited to 'activerecord/lib/active_record/schema_dumper.rb')
-rw-r--r--activerecord/lib/active_record/schema_dumper.rb15
1 files changed, 6 insertions, 9 deletions
diff --git a/activerecord/lib/active_record/schema_dumper.rb b/activerecord/lib/active_record/schema_dumper.rb
index fc28ac7cb0..a1d7e3ef24 100644
--- a/activerecord/lib/active_record/schema_dumper.rb
+++ b/activerecord/lib/active_record/schema_dumper.rb
@@ -133,18 +133,15 @@ HEADER
tbl.puts " do |t|"
- # then dump all non-primary key columns
- column_specs = columns.map do |column|
- raise StandardError, "Unknown type '#{column.sql_type}' for column '#{column.name}'" unless @connection.valid_type?(column.type)
- next if column.name == pk
- @connection.column_spec(column)
- end.compact
-
# find all migration keys used in this table
keys = @connection.migration_keys
- column_specs.each do |colspec|
- values = keys.map { |key| colspec[key] }.compact
+ # then dump all non-primary key columns
+ columns.each do |column|
+ raise StandardError, "Unknown type '#{column.sql_type}' for column '#{column.name}'" unless @connection.valid_type?(column.type)
+ next if column.name == pk
+ colspec = @connection.column_spec(column)
+ values = [column.name.inspect] + keys.map { |key| colspec[key] }.compact
tbl.puts " t.#{colspec[:type]} #{values.join(", ")}"
end