aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/sanitization.rb
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2014-12-26 15:17:10 -0700
committerSean Griffin <sean@thoughtbot.com>2014-12-26 15:19:42 -0700
commita60770d3bf3a8aeac16c110f3a7d05a6d52a86d6 (patch)
tree159a11b0566e67ce8730fbbcb17052f449434f15 /activerecord/lib/active_record/sanitization.rb
parent35362817b16e97c9db07c5d2586a95009e747b28 (diff)
downloadrails-a60770d3bf3a8aeac16c110f3a7d05a6d52a86d6.tar.gz
rails-a60770d3bf3a8aeac16c110f3a7d05a6d52a86d6.tar.bz2
rails-a60770d3bf3a8aeac16c110f3a7d05a6d52a86d6.zip
Remove `klass` and `arel_table` as a dependency of `PredicateBuilder`
This class cares far too much about the internals of other parts of Active Record. This is an attempt to break out a meaningful object which represents the needs of the predicate builder. I'm not fully satisfied with the name, but the general concept is an object which represents a table, the associations to/from that table, and the types associated with it. Many of these exist at the `ActiveRecord::Base` class level, not as properties of the table itself, hence the need for another object. Currently it provides these by holding a reference to the class, but that will likely change in the future. This allows the predicate builder to remain wholy concerned with building predicates. /cc @mrgilman
Diffstat (limited to 'activerecord/lib/active_record/sanitization.rb')
-rw-r--r--activerecord/lib/active_record/sanitization.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/sanitization.rb b/activerecord/lib/active_record/sanitization.rb
index 6c103e331f..cfe99072ca 100644
--- a/activerecord/lib/active_record/sanitization.rb
+++ b/activerecord/lib/active_record/sanitization.rb
@@ -88,7 +88,7 @@ module ActiveRecord
# # => "address_street='123 abc st.' and address_city='chicago'"
def sanitize_sql_hash_for_conditions(attrs, default_table_name = self.table_name)
table = Arel::Table.new(table_name).alias(default_table_name)
- predicate_builder = PredicateBuilder.new(self, table)
+ predicate_builder = PredicateBuilder.new(TableMetadata.new(self, table))
ActiveSupport::Deprecation.warn(<<-EOWARN)
sanitize_sql_hash_for_conditions is deprecated, and will be removed in Rails 5.0
EOWARN