diff options
| author | Sean Griffin <sean@thoughtbot.com> | 2014-10-31 11:23:24 -0600 |
|---|---|---|
| committer | Sean Griffin <sean@thoughtbot.com> | 2014-10-31 12:15:36 -0600 |
| commit | e62fff40edde10bd04bbb91ce242f4a7f7ea64a8 (patch) | |
| tree | f984582034b23691663a54fa978d5cbf4d8e403e /activerecord/lib/active_record/relation | |
| parent | 9b9f0197b7e645ae5b05a5581ba82f32f0971183 (diff) | |
| download | rails-e62fff40edde10bd04bbb91ce242f4a7f7ea64a8.tar.gz rails-e62fff40edde10bd04bbb91ce242f4a7f7ea64a8.tar.bz2 rails-e62fff40edde10bd04bbb91ce242f4a7f7ea64a8.zip | |
Treat strings greater than int max value as out of range
Sufficiently large integers cause `find` and `find_by` to raise
`StatementInvalid` instead of `RecordNotFound` or just returning `nil`.
Given that we can't cast to `nil` for `Integer` like we would with junk
data for other types, we raise a `RangeError` instead, and rescue in
places where it would be highly unexpected to get an exception from
casting.
Fixes #17380
Diffstat (limited to 'activerecord/lib/active_record/relation')
| -rw-r--r-- | activerecord/lib/active_record/relation/finder_methods.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb index ddb392a6d4..145b7378cf 100644 --- a/activerecord/lib/active_record/relation/finder_methods.rb +++ b/activerecord/lib/active_record/relation/finder_methods.rb @@ -433,6 +433,8 @@ module ActiveRecord else find_some(ids) end + rescue RangeError + raise RecordNotFound, "Couldn't find #{@klass.name} with an out of range ID" end def find_one(id) |