aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/relation
diff options
context:
space:
mode:
authorAaron Patterson <aaron.patterson@gmail.com>2014-01-13 11:44:38 -0800
committerAaron Patterson <aaron.patterson@gmail.com>2014-01-13 11:44:38 -0800
commit9b5d603c5aaa91f1d7a67a014d3ac680ad07577f (patch)
tree9013dd84e83aa722eb0414459012a640a16b55cd /activerecord/lib/active_record/relation
parent3086881001ed0007eee76f23cf54a7dda88bf792 (diff)
downloadrails-9b5d603c5aaa91f1d7a67a014d3ac680ad07577f.tar.gz
rails-9b5d603c5aaa91f1d7a67a014d3ac680ad07577f.tar.bz2
rails-9b5d603c5aaa91f1d7a67a014d3ac680ad07577f.zip
adding bind values to the manager object
Diffstat (limited to 'activerecord/lib/active_record/relation')
-rw-r--r--activerecord/lib/active_record/relation/calculations.rb6
-rw-r--r--activerecord/lib/active_record/relation/finder_methods.rb3
-rw-r--r--activerecord/lib/active_record/relation/query_methods.rb2
3 files changed, 8 insertions, 3 deletions
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
index 45ffb99868..6e868902c5 100644
--- a/activerecord/lib/active_record/relation/calculations.rb
+++ b/activerecord/lib/active_record/relation/calculations.rb
@@ -235,11 +235,14 @@ module ActiveRecord
column_alias = column_name
+ bind_values = nil
+
if operation == "count" && (relation.limit_value || relation.offset_value)
# Shortcut when limit is zero.
return 0 if relation.limit_value == 0
query_builder = build_count_subquery(relation, column_name, distinct)
+ bind_values = relation.bind_values
else
column = aggregate_column(column_name)
@@ -249,9 +252,10 @@ module ActiveRecord
relation.select_values = [select_value]
query_builder = relation.arel
+ bind_values = query_builder.bind_values + relation.bind_values
end
- result = @klass.connection.select_all(query_builder, nil, relation.bind_values)
+ result = @klass.connection.select_all(query_builder, nil, bind_values)
row = result.first
value = row && row.values.first
column = result.column_types.fetch(column_alias) do
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb
index 4984dbd277..64ac265689 100644
--- a/activerecord/lib/active_record/relation/finder_methods.rb
+++ b/activerecord/lib/active_record/relation/finder_methods.rb
@@ -255,7 +255,8 @@ module ActiveRecord
if ActiveRecord::NullRelation === relation
[]
else
- rows = connection.select_all(relation.arel, 'SQL', relation.bind_values.dup)
+ arel = relation.arel
+ rows = connection.select_all(arel, 'SQL', arel.bind_values + relation.bind_values)
join_dependency.instantiate(rows, aliases)
end
end
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb
index 6cc5585b27..7571208a88 100644
--- a/activerecord/lib/active_record/relation/query_methods.rb
+++ b/activerecord/lib/active_record/relation/query_methods.rb
@@ -1010,7 +1010,7 @@ module ActiveRecord
join_infos.each do |info|
info.joins.each { |join| manager.from(join) }
- self.bind_values += info.binds
+ manager.bind_values.concat info.binds
end
manager.join_sources.concat(join_list)