aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/relation
diff options
context:
space:
mode:
authorSimeon Simeonov <sim@fastignite.com>2013-07-20 23:08:06 -0400
committerSimeon Simeonov <sim@fastignite.com>2013-07-22 09:53:03 -0400
commit51d9b9a821a8f3f11fc5f52321df6ee05e4e1327 (patch)
tree12e94feb9cb5a5e08a94003994fd12530d977fd6 /activerecord/lib/active_record/relation
parenteda66d89c74cd573f5c0f24877fe9bf3c6a338ba (diff)
downloadrails-51d9b9a821a8f3f11fc5f52321df6ee05e4e1327.tar.gz
rails-51d9b9a821a8f3f11fc5f52321df6ee05e4e1327.tar.bz2
rails-51d9b9a821a8f3f11fc5f52321df6ee05e4e1327.zip
[Fixes #11512] improves cache size calculation in ActiveSupport::Cache::MemoryStore
Previously, the cache size of `ActiveSupport::Cache::MemoryStore` was calculated as the sum of the size of its entries, ignoring the size of keys and any data structure overhead. This could lead to the calculated cache size sometimes being 10-100x smaller than the memory used, e.g., in the case of small values. The size of a key/entry pair is now calculated via `#cached_size`: def cached_size(key, entry) key.to_s.bytesize + entry.size + PER_ENTRY_OVERHEAD end The value of `PER_ENTRY_OVERHEAD` is 240 bytes based on an [empirical estimation](https://gist.github.com/ssimeonov/6047200) for 64-bit MRI on 1.9.3 and 2.0. Fixes GH#11512 https://github.com/rails/rails/issues/11512
Diffstat (limited to 'activerecord/lib/active_record/relation')
0 files changed, 0 insertions, 0 deletions