diff options
author | Godfrey Chan <godfreykfc@gmail.com> | 2014-08-28 09:19:11 -0700 |
---|---|---|
committer | Godfrey Chan <godfreykfc@gmail.com> | 2014-08-28 09:19:11 -0700 |
commit | 8c52480ba6071a12b97f124d9f21df2c39df3ed3 (patch) | |
tree | b0c41cbee61c699f74ae6a09dbab4b604f8df122 /activerecord/lib/active_record/relation/query_methods.rb | |
parent | 4e68c5dc5712e1d560d3ade694e3f840637baa47 (diff) | |
download | rails-8c52480ba6071a12b97f124d9f21df2c39df3ed3.tar.gz rails-8c52480ba6071a12b97f124d9f21df2c39df3ed3.tar.bz2 rails-8c52480ba6071a12b97f124d9f21df2c39df3ed3.zip |
Avoid using heredoc for user warnings
Using heredoc would enforce line wrapping to whatever column width we decided to
use in the code, making it difficult for the users to read on some consoles.
This does make the source code read slightly worse and a bit more error-prone,
but this seems like a fair price to pay since the primary purpose for these
messages are for the users to read and the code will not stick around for too
long.
Diffstat (limited to 'activerecord/lib/active_record/relation/query_methods.rb')
-rw-r--r-- | activerecord/lib/active_record/relation/query_methods.rb | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index 067966321d..e59cce6934 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -94,10 +94,8 @@ module ActiveRecord def check_cached_relation # :nodoc: if defined?(@arel) && @arel @arel = nil - ActiveSupport::Deprecation.warn <<-WARNING -Modifying already cached Relation. The cache will be reset. -Use a cloned Relation to prevent this warning. -WARNING + ActiveSupport::Deprecation.warn "Modifying already cached Relation. The " \ + "cache will be reset. Use a cloned Relation to prevent this warning." end end |