aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/relation/predicate_builder.rb
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2014-11-26 13:22:11 -0700
committerSean Griffin <sean@thoughtbot.com>2014-11-29 15:49:18 -0700
commitde239066e32d654f6815a94cdf8ce4b67b058726 (patch)
tree825d046317dad1cda8f2b4449a2ff7dbe15cc5ef /activerecord/lib/active_record/relation/predicate_builder.rb
parent5493d16d9e2fbc8efb0535c7a704a83d460a1beb (diff)
downloadrails-de239066e32d654f6815a94cdf8ce4b67b058726.tar.gz
rails-de239066e32d654f6815a94cdf8ce4b67b058726.tar.bz2
rails-de239066e32d654f6815a94cdf8ce4b67b058726.zip
Stop using `Arel::Table.engine`
We never actually make use of it on the table, since we're constructing the select manager manually. It looks like if we ever actually were grabbing it from the table, we're grossly misusing it since it's meant to vary by AR class. Its existence on `Arel::Table` appears to be purely for convenience methods that are never used outside of tests. However, in production code it just complicates construction of the tables on the rails side, and the plan is to remove it from `Arel::Table` entirely. I'm not convinced it needs to live on `SelectManager`, etc either.
Diffstat (limited to 'activerecord/lib/active_record/relation/predicate_builder.rb')
-rw-r--r--activerecord/lib/active_record/relation/predicate_builder.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/relation/predicate_builder.rb b/activerecord/lib/active_record/relation/predicate_builder.rb
index e4b6b49087..938bf55c6d 100644
--- a/activerecord/lib/active_record/relation/predicate_builder.rb
+++ b/activerecord/lib/active_record/relation/predicate_builder.rb
@@ -25,7 +25,7 @@ module ActiveRecord
if value.empty?
queries << '1=0'
else
- table = Arel::Table.new(column, default_table.engine)
+ table = Arel::Table.new(column)
association = klass._reflect_on_association(column)
value.each do |k, v|
@@ -37,7 +37,7 @@ module ActiveRecord
if column.include?('.')
table_name, column = column.split('.', 2)
- table = Arel::Table.new(table_name, default_table.engine)
+ table = Arel::Table.new(table_name)
end
queries.concat expand(klass, table, column, value)