diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2017-07-17 17:19:56 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2017-07-17 17:33:32 +0900 |
| commit | a0ebab52b2a708a09739e0c4ecc16ad16d4e676d (patch) | |
| tree | 05fd4ba84c0a6ce986ea9766fcb12b1e2b211bb9 /activerecord/lib/active_record/relation/finder_methods.rb | |
| parent | fbade51248ea48db87703ba7418badbd3ed85e36 (diff) | |
| download | rails-a0ebab52b2a708a09739e0c4ecc16ad16d4e676d.tar.gz rails-a0ebab52b2a708a09739e0c4ecc16ad16d4e676d.tar.bz2 rails-a0ebab52b2a708a09739e0c4ecc16ad16d4e676d.zip | |
Remove useless `arel_engine`
`arel_engine` is only used in `raise_record_not_found_exception!` to use
`engine.connection` (and `connection.visitor`) in `arel.where_sql`.
https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L183
But `klass.connection` will work as expected even if not using
`arel_engine` (described by `test_connection`). So `arel_engine` is no
longer needed.
Diffstat (limited to 'activerecord/lib/active_record/relation/finder_methods.rb')
| -rw-r--r-- | activerecord/lib/active_record/relation/finder_methods.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb index ac0b4f597e..7121dcade8 100644 --- a/activerecord/lib/active_record/relation/finder_methods.rb +++ b/activerecord/lib/active_record/relation/finder_methods.rb @@ -329,7 +329,7 @@ module ActiveRecord # the expected number of results should be provided in the +expected_size+ # argument. def raise_record_not_found_exception!(ids = nil, result_size = nil, expected_size = nil, key = primary_key) # :nodoc: - conditions = arel.where_sql(@klass.arel_engine) + conditions = arel.where_sql(@klass) conditions = " [#{conditions}]" if conditions name = @klass.name |