diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2017-05-11 12:44:05 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2017-05-11 12:52:32 +0900 |
| commit | 07a611e02351b32100f19495a34ed46d01f195c1 (patch) | |
| tree | c07e9bdb83b0703df3cb026215f1a29d15d5903f /activerecord/lib/active_record/relation/finder_methods.rb | |
| parent | 97bd56e674603529d96c6f6e85d695dd24208afb (diff) | |
| download | rails-07a611e02351b32100f19495a34ed46d01f195c1.tar.gz rails-07a611e02351b32100f19495a34ed46d01f195c1.tar.bz2 rails-07a611e02351b32100f19495a34ed46d01f195c1.zip | |
Don't eager loading if unneeded for `FinderMethods#exists?`
Fixes #29025.
Diffstat (limited to 'activerecord/lib/active_record/relation/finder_methods.rb')
| -rw-r--r-- | activerecord/lib/active_record/relation/finder_methods.rb | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb index a1459c87c6..1d661fa8ed 100644 --- a/activerecord/lib/active_record/relation/finder_methods.rb +++ b/activerecord/lib/active_record/relation/finder_methods.rb @@ -307,9 +307,11 @@ module ActiveRecord MSG end - return false if !conditions + return false if !conditions || limit_value == 0 + + relation = self unless eager_loading? + relation ||= apply_join_dependency(self, construct_join_dependency(eager_loading: false)) - relation = apply_join_dependency(self, construct_join_dependency(eager_loading: false)) return false if ActiveRecord::NullRelation === relation relation = construct_relation_for_exists(relation, conditions) |