diff options
| author | Akira Matsuda <ronnie@dio.jp> | 2017-01-05 17:20:57 +0900 |
|---|---|---|
| committer | Akira Matsuda <ronnie@dio.jp> | 2017-01-05 19:58:52 +0900 |
| commit | 5473e390d362755125d2f47b64ef0a135f2fe111 (patch) | |
| tree | b9c199a3c78ad307ed034cf5618e2897dfa650c6 /activerecord/lib/active_record/relation/calculations.rb | |
| parent | 6197a38bca988f05087aa022e288922cf0331d6c (diff) | |
| download | rails-5473e390d362755125d2f47b64ef0a135f2fe111.tar.gz rails-5473e390d362755125d2f47b64ef0a135f2fe111.tar.bz2 rails-5473e390d362755125d2f47b64ef0a135f2fe111.zip | |
`self.` is not needed when calling its own instance method
Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
Diffstat (limited to 'activerecord/lib/active_record/relation/calculations.rb')
| -rw-r--r-- | activerecord/lib/active_record/relation/calculations.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb index 827688a663..35c670f1a1 100644 --- a/activerecord/lib/active_record/relation/calculations.rb +++ b/activerecord/lib/active_record/relation/calculations.rb @@ -193,7 +193,7 @@ module ActiveRecord # If #count is used with #distinct (i.e. `relation.distinct.count`) it is # considered distinct. - distinct = self.distinct_value + distinct = distinct_value if operation == "count" column_name ||= select_for_count |