diff options
| author | Daniel Colson <danieljamescolson@gmail.com> | 2018-01-29 07:22:42 -0500 |
|---|---|---|
| committer | Daniel Colson <danieljamescolson@gmail.com> | 2018-01-29 07:22:42 -0500 |
| commit | 2e8c8d60e7568f9fb82fbed26d86c45d3cf82232 (patch) | |
| tree | 908fcb1c16474887a4f49985754b1be4e20c603f /activerecord/lib/active_record/relation/calculations.rb | |
| parent | bee764965e80b0f4f0a15c31b340f245779a7d89 (diff) | |
| download | rails-2e8c8d60e7568f9fb82fbed26d86c45d3cf82232.tar.gz rails-2e8c8d60e7568f9fb82fbed26d86c45d3cf82232.tar.bz2 rails-2e8c8d60e7568f9fb82fbed26d86c45d3cf82232.zip | |
Avoid extra calls to to_s
With #31615 `type_for_attribute` accepts either
a symbol as well as a string. `has_attribute?` and `attribute_alias`
also accept either. Since these methods call `to_s` on the argument,
we no longer need to do that at the call site.
Diffstat (limited to 'activerecord/lib/active_record/relation/calculations.rb')
| -rw-r--r-- | activerecord/lib/active_record/relation/calculations.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb index decd60c87f..dba2f33dd4 100644 --- a/activerecord/lib/active_record/relation/calculations.rb +++ b/activerecord/lib/active_record/relation/calculations.rb @@ -242,7 +242,7 @@ module ActiveRecord def aggregate_column(column_name) return column_name if Arel::Expressions === column_name - if @klass.has_attribute?(column_name.to_s) || @klass.attribute_alias?(column_name.to_s) + if @klass.has_attribute?(column_name) || @klass.attribute_alias?(column_name) @klass.arel_attribute(column_name) else Arel.sql(column_name == :all ? "*" : column_name.to_s) |