Assign the `#alias_name` to each reflection

This makes the `#alias_name` more functional.

1 files changed, 3 insertions, 7 deletions

diff --git a/activerecord/lib/active_record/reflection.rb b/activerecord/lib/active_record/reflection.rb
index ea469f881c..79c6504a18 100644
--- a/activerecord/lib/active_record/reflection.rb
+++ b/activerecord/lib/active_record/reflection.rb
@@ -936,7 +936,7 @@ module ActiveRecord
     end
 
     class RuntimeReflection < PolymorphicReflection
-      attr_accessor :next
+      attr_accessor :next, :alias_name
 
       def initialize(reflection, association)
         @reflection = reflection
@@ -959,12 +959,8 @@ module ActiveRecord
         @reflection.source_type_info
       end
 
-      def alias_name(name, alias_tracker)
-        @alias ||= begin
-          alias_name = "#{plural_name}_#{name}_join"
-          table_name = klass.table_name
-          alias_tracker.aliased_table_for(table_name, alias_name)
-        end
+      def alias_candidate(name)
+        "#{plural_name}_#{name}_join"
       end
     end
   end