diff options
author | Yasuo Honda <yasuo.honda@gmail.com> | 2018-05-07 09:22:23 +0000 |
---|---|---|
committer | Yasuo Honda <yasuo.honda@gmail.com> | 2018-05-22 02:08:08 +0000 |
commit | 45881b0a64b4039e3b0d27e2c4d959dc2d744b9d (patch) | |
tree | 65e402e81ee4ce49cabcaf02f4c30540eb109600 /activerecord/lib/active_record/migration.rb | |
parent | 054893d574f9c5eebc13d3749680f3a264e4b57d (diff) | |
download | rails-45881b0a64b4039e3b0d27e2c4d959dc2d744b9d.tar.gz rails-45881b0a64b4039e3b0d27e2c4d959dc2d744b9d.tar.bz2 rails-45881b0a64b4039e3b0d27e2c4d959dc2d744b9d.zip |
Disable foreign keys during `alter_table` for sqlite3 adapter
Unlike other databases, changing SQLite3 table definitions need to create a temporary table.
While changing table operations, the original table needs dropped which caused
`SQLite3::ConstraintException: FOREIGN KEY constraint failed` if the table is referenced by foreign keys.
This pull request disables foreign keys by `disable_referential_integrity`.
Also `disable_referential_integrity` method needs to execute `defer_foreign_keys = ON`
to defer re-enabling foreign keys until the transaction is committed.
https://www.sqlite.org/pragma.html#pragma_defer_foreign_keys
Fixes #31988
- This `defer_foreign_keys = ON` has been supported since SQLite 3.8.0
https://www.sqlite.org/releaselog/3_8_0.html and Rails 6 requires SQLite 3.8 #32923 now
- <Models>.reset_column_information added to address `ActiveModel::UnknownAttributeError`
```
Error:
ActiveRecord::Migration::ForeignKeyChangeColumnTest#test_change_column_of_parent_table:
ActiveModel::UnknownAttributeError: unknown attribute 'name' for ActiveRecord::Migration::ForeignKeyChangeColumnTest::Post.
```
Diffstat (limited to 'activerecord/lib/active_record/migration.rb')
0 files changed, 0 insertions, 0 deletions