aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/insert_all.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2019-04-10 09:56:29 +0900
committerRyuta Kamizono <kamipo@gmail.com>2019-04-10 09:56:29 +0900
commit04d30dae61f4a69d125e407551392f3adfff050e (patch)
tree318bed81d7933c8187d57165a0fc5efd5a506050 /activerecord/lib/active_record/insert_all.rb
parent8976507439f37bff7300fcc09de45f2f299339b7 (diff)
downloadrails-04d30dae61f4a69d125e407551392f3adfff050e.tar.gz
rails-04d30dae61f4a69d125e407551392f3adfff050e.tar.bz2
rails-04d30dae61f4a69d125e407551392f3adfff050e.zip
There is no need to create `QueryAttribute` to just type cast a value
Diffstat (limited to 'activerecord/lib/active_record/insert_all.rb')
-rw-r--r--activerecord/lib/active_record/insert_all.rb3
1 files changed, 1 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/insert_all.rb b/activerecord/lib/active_record/insert_all.rb
index ed7a37b255..959e5bd4d7 100644
--- a/activerecord/lib/active_record/insert_all.rb
+++ b/activerecord/lib/active_record/insert_all.rb
@@ -128,8 +128,7 @@ module ActiveRecord
types = extract_types_from_columns_on(model.table_name, keys: keys)
values_list = insert_all.map_key_with_value do |key, value|
- bind = Relation::QueryAttribute.new(key, value, types[key])
- connection.with_yaml_fallback(bind.value_for_database)
+ connection.with_yaml_fallback(types[key].serialize(value))
end
Arel::InsertManager.new.create_values_list(values_list).to_sql