diff options
| author | Aaron Weiner <aweiner@mdsol.com> | 2013-02-27 18:17:29 -0500 |
|---|---|---|
| committer | Aaron Weiner <aweiner@mdsol.com> | 2013-03-03 12:36:51 -0500 |
| commit | 53f18f2c5475809f7f6c5576aba89d6340a57c06 (patch) | |
| tree | d1ae1d758acc64933ac592866b5b94745ded553b /activerecord/lib/active_record/inheritance.rb | |
| parent | 48c21e3255fa2f4b1875ca8616a5ad7706a7a4cb (diff) | |
| download | rails-53f18f2c5475809f7f6c5576aba89d6340a57c06.tar.gz rails-53f18f2c5475809f7f6c5576aba89d6340a57c06.tar.bz2 rails-53f18f2c5475809f7f6c5576aba89d6340a57c06.zip | |
More helpful error message when instantiating an abstract class
Calling a literal ActiveRecord::Base.new raises NoMethodError,
since it ends up calling Class.abstract_class? which does not exist.
Similarly, instantiating an actual abstract class hits the database,
when conventionally it should immediately throw NotImplementedError.
ActiveRecord::Base can't be made abstract without breaking many,
many things, so check for it separately.
Diffstat (limited to 'activerecord/lib/active_record/inheritance.rb')
| -rw-r--r-- | activerecord/lib/active_record/inheritance.rb | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/activerecord/lib/active_record/inheritance.rb b/activerecord/lib/active_record/inheritance.rb index e630897a4b..13a8352f13 100644 --- a/activerecord/lib/active_record/inheritance.rb +++ b/activerecord/lib/active_record/inheritance.rb @@ -15,6 +15,9 @@ module ActiveRecord # and if the inheritance column is attr accessible, it initializes an # instance of the given subclass instead of the base class def new(*args, &block) + if abstract_class? || self == Base + raise NotImplementedError, "#{self} is an abstract class and can not be instantiated." + end if (attrs = args.first).is_a?(Hash) if subclass = subclass_from_attrs(attrs) return subclass.new(*args, &block) |