diff options
| author | Sean Griffin <sean@thoughtbot.com> | 2014-11-18 15:19:15 -0800 |
|---|---|---|
| committer | Sean Griffin <sean@thoughtbot.com> | 2014-11-18 15:20:19 -0800 |
| commit | 08576b94ad4f19dfc368619d7751e211d23dcad8 (patch) | |
| tree | a8be0f668e65f0c90a79cd3031984c507225019c /activerecord/lib/active_record/enum.rb | |
| parent | 78e7a0d3b7eaafe1ad0a45e3e355e1123cae3f8b (diff) | |
| download | rails-08576b94ad4f19dfc368619d7751e211d23dcad8.tar.gz rails-08576b94ad4f19dfc368619d7751e211d23dcad8.tar.bz2 rails-08576b94ad4f19dfc368619d7751e211d23dcad8.zip | |
Improve the performance of reading attributes
We added a comparison to "id", and call to `self.class.primary_key` a
*lot*. We also have performance hits from `&block` all over the place.
We skip the check in a new method, in order to avoid breaking the
behavior of `read_attribute`
Diffstat (limited to 'activerecord/lib/active_record/enum.rb')
| -rw-r--r-- | activerecord/lib/active_record/enum.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/enum.rb b/activerecord/lib/active_record/enum.rb index 5958373e88..f053372cfb 100644 --- a/activerecord/lib/active_record/enum.rb +++ b/activerecord/lib/active_record/enum.rb @@ -142,7 +142,7 @@ module ActiveRecord private def save_changed_attribute(attr_name, old) if (mapping = self.class.defined_enums[attr_name.to_s]) - value = read_attribute(attr_name) + value = _read_attribute(attr_name) if attribute_changed?(attr_name) if mapping[old] == value clear_attribute_changes([attr_name]) |