diff options
| author | Richard Macklin <richard.github@nrm.com> | 2019-04-20 19:09:50 -0700 |
|---|---|---|
| committer | Richard Macklin <richard.github@nrm.com> | 2019-04-20 19:32:30 -0700 |
| commit | ef12ccfd8bc42d88611dea1190988214836b951c (patch) | |
| tree | f4c74e4219da33f8f4ed019cea5629d2a348fd4c /activerecord/lib/active_record/define_callbacks.rb | |
| parent | 80b7d58f34a965fc0269ab7e0efa86d39b86be56 (diff) | |
| download | rails-ef12ccfd8bc42d88611dea1190988214836b951c.tar.gz rails-ef12ccfd8bc42d88611dea1190988214836b951c.tar.bz2 rails-ef12ccfd8bc42d88611dea1190988214836b951c.zip | |
Make system tests take failed screenshots in `before_teardown` hook
Previously we were calling the `take_failed_screenshot` method in an
`after_teardown` hook. However, this means that other teardown hooks
have to be executed before we take the screenshot. Since there can be
dynamic updates to the page after the assertion fails and before we
take a screenshot, it seems desirable to minimize that gap as much as
possible. Taking the screenshot in a `before_teardown` rather than an
`after_teardown` helps with that, and has a side benefit of allowing
us to remove the nested `ensure` commented on here:
https://github.com/rails/rails/pull/34411#discussion_r232819478
Diffstat (limited to 'activerecord/lib/active_record/define_callbacks.rb')
0 files changed, 0 insertions, 0 deletions