diff options
| author | Sean Griffin <sean@seantheprogrammer.com> | 2016-08-31 08:54:38 -0400 |
|---|---|---|
| committer | Sean Griffin <sean@seantheprogrammer.com> | 2016-08-31 09:26:25 -0400 |
| commit | caa178c178468f7adcc5f4c597280e6362d9e175 (patch) | |
| tree | 92e31877f28485d694d5e55bc315ef36b924ca37 /activerecord/lib/active_record/core.rb | |
| parent | 0ca595ea6e3a9523b7902b05305437054de67e43 (diff) | |
| download | rails-caa178c178468f7adcc5f4c597280e6362d9e175.tar.gz rails-caa178c178468f7adcc5f4c597280e6362d9e175.tar.bz2 rails-caa178c178468f7adcc5f4c597280e6362d9e175.zip | |
Ensure that inverse associations are set before running callbacks
If a parent association was accessed in an `after_find` or
`after_initialize` callback, it would always end up loading the
association, and then immediately overwriting the association we just
loaded. If this occurred in a way that the parent's `current_scope` was
set to eager load the child, this would result in an infinite loop and
eventually overflow the stack.
For records that are created with `.new`, we have a mechanism to
perform an action before the callbacks are run. I've introduced the same
code path for records created with `instantiate`, and updated all code
which sets inverse instances on newly loaded associations to use this
block instead.
Fixes #26320.
Diffstat (limited to 'activerecord/lib/active_record/core.rb')
| -rw-r--r-- | activerecord/lib/active_record/core.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/activerecord/lib/active_record/core.rb b/activerecord/lib/active_record/core.rb index aef4761be4..2725c85446 100644 --- a/activerecord/lib/active_record/core.rb +++ b/activerecord/lib/active_record/core.rb @@ -366,6 +366,8 @@ module ActiveRecord self.class.define_attribute_methods + yield self if block_given? + _run_find_callbacks _run_initialize_callbacks |