aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/core.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2018-05-19 11:46:03 +0900
committerRyuta Kamizono <kamipo@gmail.com>2019-04-16 12:30:45 +0900
commit63ff495bdf90e0ab20114a49db5cffe3cb9ef2fd (patch)
tree33d5e390a602ef7c77a2c675865b573802fdd35b /activerecord/lib/active_record/core.rb
parent20b94af9eb9305d19a343f72f0afb18eb49e2de7 (diff)
downloadrails-63ff495bdf90e0ab20114a49db5cffe3cb9ef2fd.tar.gz
rails-63ff495bdf90e0ab20114a49db5cffe3cb9ef2fd.tar.bz2
rails-63ff495bdf90e0ab20114a49db5cffe3cb9ef2fd.zip
Fix dirty tracking after rollback.
Currently the rollback only restores primary key value, `new_record?`, `destroyed?`, and `frozen?`. Since the `save` clears current dirty attribute states, retrying save after rollback will causes no change saved if partial writes is enabled (by default). This makes `remember_transaction_record_state` remembers original values then restores dirty attribute states after rollback. Fixes #15018. Fixes #30167. Fixes #33868. Fixes #33443. Closes #33444. Closes #34504.
Diffstat (limited to 'activerecord/lib/active_record/core.rb')
-rw-r--r--activerecord/lib/active_record/core.rb6
1 files changed, 0 insertions, 6 deletions
diff --git a/activerecord/lib/active_record/core.rb b/activerecord/lib/active_record/core.rb
index 6fed3e5c19..04b21b4d00 100644
--- a/activerecord/lib/active_record/core.rb
+++ b/activerecord/lib/active_record/core.rb
@@ -583,12 +583,6 @@ module ActiveRecord
def initialize_internals_callback
end
- def thaw
- if @attributes.frozen?
- @attributes = @attributes.dup
- end
- end
-
def custom_inspect_method_defined?
self.class.instance_method(:inspect).owner != ActiveRecord::Base.instance_method(:inspect).owner
end