aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters
diff options
context:
space:
mode:
authorMarcel Molina <marcel@vernix.org>2006-05-14 18:37:22 +0000
committerMarcel Molina <marcel@vernix.org>2006-05-14 18:37:22 +0000
commit9c5591da2dd9404ac189690ad59670ec7d364b16 (patch)
tree82211ae534882e127cf11a88a78ba5da0366421d /activerecord/lib/active_record/connection_adapters
parentf2b3deb85cab1389d6b895b2e45b33054a96a6ba (diff)
downloadrails-9c5591da2dd9404ac189690ad59670ec7d364b16.tar.gz
rails-9c5591da2dd9404ac189690ad59670ec7d364b16.tar.bz2
rails-9c5591da2dd9404ac189690ad59670ec7d364b16.zip
Preserve MySQL boolean column defaults when changing a column in a migration. Closes #5015. [pdcawley@bofh.org.uk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters')
-rwxr-xr-xactiverecord/lib/active_record/connection_adapters/mysql_adapter.rb4
-rw-r--r--activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb2
2 files changed, 4 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
index 7a697c2335..417eca180e 100755
--- a/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
@@ -308,7 +308,9 @@ module ActiveRecord
end
def change_column(table_name, column_name, type, options = {}) #:nodoc:
- options[:default] ||= select_one("SHOW COLUMNS FROM #{table_name} LIKE '#{column_name}'")["Default"]
+ if options[:default].nil?
+ options[:default] = select_one("SHOW COLUMNS FROM #{table_name} LIKE '#{column_name}'")["Default"]
+ end
change_column_sql = "ALTER TABLE #{table_name} CHANGE #{column_name} #{column_name} #{type_to_sql(type, options[:limit])}"
add_column_options!(change_column_sql, options)
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
index ba219b9799..cf4114aacc 100644
--- a/activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
@@ -243,7 +243,7 @@ module ActiveRecord
definition[column_name].instance_eval do
self.type = type
self.limit = options[:limit] if options[:limit]
- self.default = options[:default] if options[:default]
+ self.default = options[:default] unless options[:default].nil?
end
end
end