diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2018-07-09 11:23:37 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2018-07-09 11:23:37 +0900 |
| commit | 544492d04f10beb007df0db968c24bed140a1c4f (patch) | |
| tree | b6c5e9dce107ea93e5bc7b89e70d2fd9caef916f /activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb | |
| parent | f7c5a8ce262cf16ad8d7c0b0d631a4b88afec414 (diff) | |
| download | rails-544492d04f10beb007df0db968c24bed140a1c4f.tar.gz rails-544492d04f10beb007df0db968c24bed140a1c4f.tar.bz2 rails-544492d04f10beb007df0db968c24bed140a1c4f.zip | |
SQLite: Don't leak internal schema objects
Related #31201.
If creating custom primary key (like a string) in SQLite, it would also
create an internal index implicitly which named begin with "sqlite_".
It need to be hidden since the internal object names are reserved and
prohibited for public use.
See https://www.sqlite.org/fileformat2.html#intschema
Fixes #33320.
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb')
| -rw-r--r-- | activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb index 844af952c1..bee74dc33d 100644 --- a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb @@ -457,9 +457,6 @@ module ActiveRecord def copy_table_indexes(from, to, rename = {}) indexes(from).each do |index| name = index.name - # indexes sqlite creates for internal use start with `sqlite_` and - # don't need to be copied - next if name.starts_with?("sqlite_") if to == "a#{from}" name = "t#{name}" elsif from == "a#{to}" |