diff options
author | Rafael França <rafaelmfranca@gmail.com> | 2019-04-09 16:31:31 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-04-09 16:31:31 -0400 |
commit | 8976507439f37bff7300fcc09de45f2f299339b7 (patch) | |
tree | 821196531c6eafcf5b91a17ff64497ee96ee9bd8 /activerecord/lib/active_record/connection_adapters/sql_type_metadata.rb | |
parent | 21ce5cf6f112b5eee5f125089351427ff8f91a54 (diff) | |
parent | 6f26e99cef4b6f20be8ef5cf7fee4b4755baaaec (diff) | |
download | rails-8976507439f37bff7300fcc09de45f2f299339b7.tar.gz rails-8976507439f37bff7300fcc09de45f2f299339b7.tar.bz2 rails-8976507439f37bff7300fcc09de45f2f299339b7.zip |
Merge pull request #35875 from Shopify/alloc-free-comparisons
Improve == and hash methods on various schema cache structs to be allocation free.
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/sql_type_metadata.rb')
-rw-r--r-- | activerecord/lib/active_record/connection_adapters/sql_type_metadata.rb | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/sql_type_metadata.rb b/activerecord/lib/active_record/connection_adapters/sql_type_metadata.rb index 8489bcbf1d..df28df7a7c 100644 --- a/activerecord/lib/active_record/connection_adapters/sql_type_metadata.rb +++ b/activerecord/lib/active_record/connection_adapters/sql_type_metadata.rb @@ -16,19 +16,22 @@ module ActiveRecord def ==(other) other.is_a?(SqlTypeMetadata) && - attributes_for_hash == other.attributes_for_hash + sql_type == other.sql_type && + type == other.type && + limit == other.limit && + precision == other.precision && + scale == other.scale end alias eql? == def hash - attributes_for_hash.hash + SqlTypeMetadata.hash ^ + sql_type.hash ^ + type.hash ^ + limit.hash ^ + precision.hash >> 1 ^ + scale.hash >> 2 end - - protected - - def attributes_for_hash - [self.class, sql_type, type, limit, precision, scale] - end end end end |