Revert "PERF: optimise type lookup to avoid invoking procs"

This reverts commit da99a2a2982d35f670ad9647463e09bfe9032b70.

1 files changed, 7 insertions, 13 deletions

diff --git a/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb b/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
index d3e5b0a4ad..6310d70192 100644
--- a/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
@@ -431,22 +431,16 @@ module ActiveRecord
       private
 
         def get_oid_type(oid, fmod, column_name, sql_type = '') # :nodoc:
-
-          result = type_map.fetch(oid, fmod, sql_type) {
-            nil
-          }
-
-          unless result
+          if !type_map.key?(oid)
             load_additional_types(type_map, [oid])
-            result = type_map.fetch(oid, fmod, sql_type) {
-              warn "unknown OID #{oid}: failed to recognize type of '#{column_name}'. It will be treated as String."
-              Type::Value.new.tap do |cast_type|
-                type_map.register_type(oid, cast_type)
-              end
-            }
           end
 
-          result
+          type_map.fetch(oid, fmod, sql_type) {
+            warn "unknown OID #{oid}: failed to recognize type of '#{column_name}'. It will be treated as String."
+            Type::Value.new.tap do |cast_type|
+              type_map.register_type(oid, cast_type)
+            end
+          }
         end
 
         def initialize_type_map(m) # :nodoc: