aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2016-02-19 08:33:56 +0900
committerRyuta Kamizono <kamipo@gmail.com>2016-02-19 08:33:56 +0900
commit54accc0a6fbc345844879fa8792aa7827d2d3531 (patch)
tree967c18bb00b5d36e42041428a2cacfff102aee71 /activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
parent042bfb8715ca301dc37e5e883951f6aa07fbc7ea (diff)
downloadrails-54accc0a6fbc345844879fa8792aa7827d2d3531.tar.gz
rails-54accc0a6fbc345844879fa8792aa7827d2d3531.tar.bz2
rails-54accc0a6fbc345844879fa8792aa7827d2d3531.zip
Remove `alias exec_without_stmt exec_query`
This alias was for compatibility with legacy mysql adapter. But the return value of both methods is already inconsistent. `exec_query` returns `ActiveRecord::Result` instance. But `exec_without_stmt` returns `[result_set, affected_rows]` https://github.com/rails/rails/blob/v4.2.5.1/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb#L335-L364 Legacy mysql adapter was already removed in Rails 5.0. I think we can remove this inconsistent alias.
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb')
-rw-r--r--activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb2
1 files changed, 0 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb b/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
index 23b33a3555..57d8867bb4 100644
--- a/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
@@ -134,8 +134,6 @@ module ActiveRecord
ActiveRecord::Result.new(result.fields, result.to_a)
end
- alias exec_without_stmt exec_query
-
def exec_insert(sql, name, binds, pk = nil, sequence_name = nil)
execute to_sql(sql, binds), name
end