aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2016-08-14 06:17:20 +0900
committerRyuta Kamizono <kamipo@gmail.com>2016-08-19 12:11:26 +0900
commit99cb16a2babfb10b8c2bc3270a38fcb3ca92bb09 (patch)
treeb7132e8de07a5bafbb5fd432fb38047408fd8b05 /activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb
parent28aaf77bb07af5e0108ff986e192e71da6d25078 (diff)
downloadrails-99cb16a2babfb10b8c2bc3270a38fcb3ca92bb09.tar.gz
rails-99cb16a2babfb10b8c2bc3270a38fcb3ca92bb09.tar.bz2
rails-99cb16a2babfb10b8c2bc3270a38fcb3ca92bb09.zip
Remove text default treated as an empty string in non-strict mode
Strict mode controls how MySQL handles invalid or missing values in data-change statements such as INSERT or UPDATE. If strict mode is not in effect, MySQL inserts adjusted values for invalid or missing values and produces warnings. ```ruby def test_mysql_not_null_defaults_non_strict using_strict(false) do with_mysql_not_null_table do |klass| record = klass.new assert_nil record.non_null_integer assert_nil record.non_null_string assert_nil record.non_null_text assert_nil record.non_null_blob record.save! record.reload assert_equal 0, record.non_null_integer assert_equal "", record.non_null_string assert_equal "", record.non_null_text assert_equal "", record.non_null_blob end end end ``` It is inconsistent with other types that only text/blob defaults treated as an empty string. This commit fixes the inconsistency.
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb')
-rw-r--r--activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb7
1 files changed, 3 insertions, 4 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb b/activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb
index 1be5cb4740..24dcf852e1 100644
--- a/activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb
+++ b/activerecord/lib/active_record/connection_adapters/mysql/type_metadata.rb
@@ -2,13 +2,12 @@ module ActiveRecord
module ConnectionAdapters
module MySQL
class TypeMetadata < DelegateClass(SqlTypeMetadata) # :nodoc:
- attr_reader :extra, :strict
+ attr_reader :extra
- def initialize(type_metadata, extra: "", strict: false)
+ def initialize(type_metadata, extra: "")
super(type_metadata)
@type_metadata = type_metadata
@extra = extra
- @strict = strict
end
def ==(other)
@@ -24,7 +23,7 @@ module ActiveRecord
protected
def attributes_for_hash
- [self.class, @type_metadata, extra, strict]
+ [self.class, @type_metadata, extra]
end
end
end