Refactor `ColumnDefinition` to contain `options` hash

Column options are passed as an hash args then used as `options` hash in
`add_column_options!`. Converting args to attributes is inconvinient for
using options as an hash.

1 files changed, 3 insertions, 16 deletions

diff --git a/activerecord/lib/active_record/connection_adapters/mysql/schema_definitions.rb b/activerecord/lib/active_record/connection_adapters/mysql/schema_definitions.rb
index 76ebd0bf6c..773bbcef4e 100644
--- a/activerecord/lib/active_record/connection_adapters/mysql/schema_definitions.rb
+++ b/activerecord/lib/active_record/connection_adapters/mysql/schema_definitions.rb
@@ -56,14 +56,10 @@ module ActiveRecord
         end
       end
 
-      class ColumnDefinition < ActiveRecord::ConnectionAdapters::ColumnDefinition
-        attr_accessor :charset, :unsigned, :stored
-      end
-
       class TableDefinition < ActiveRecord::ConnectionAdapters::TableDefinition
         include ColumnMethods
 
-        def new_column_definition(name, type, options) # :nodoc:
+        def new_column_definition(name, type, **options) # :nodoc:
           case type
           when :virtual
             type = options[:type]
@@ -76,18 +72,9 @@ module ActiveRecord
             type = $~[:type].to_sym
             options[:unsigned] = true
           end
-          column = super
-          column.unsigned = options[:unsigned]
-          column.charset = options[:charset]
-          column.stored = options[:stored]
-          column
-        end
-
-        private
 
-          def create_column_definition(name, type)
-            MySQL::ColumnDefinition.new(name, type)
-          end
+          super
+        end
       end
 
       class Table < ActiveRecord::ConnectionAdapters::Table