diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2017-04-05 11:35:47 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2017-05-01 01:32:36 +0900 |
| commit | 9caa0cf57d2f73b3ad6c34f00c34b5fdf75fe8fd (patch) | |
| tree | 53ba181a4e7eb26b955a2196c3bbfbc60e2b5b75 /activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb | |
| parent | 7cb71c5ce37b7bc599de851d44eaa6a948daec03 (diff) | |
| download | rails-9caa0cf57d2f73b3ad6c34f00c34b5fdf75fe8fd.tar.gz rails-9caa0cf57d2f73b3ad6c34f00c34b5fdf75fe8fd.tar.bz2 rails-9caa0cf57d2f73b3ad6c34f00c34b5fdf75fe8fd.zip | |
Deprecate `supports_statement_cache?`
`supports_statement_cache?` was introduced in 3.1.0.beta1 (104d0b2) for
bind parameter substitution, but it is no longer used in 3.1.0.rc1
(73ff679). Originally it should respect `prepared_statements` rather
than `supports_statement_cache?` (fd39847).
One more thing, named `supports_statement_cache?` is pretty misreading.
We have `StatementCache` and `StatementPool`. However,
`supports_statement_cache?` doesn't mean `StatementCache`, but
`StatementPool` unlike its name.
https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/statement_cache.rb
https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/connection_adapters/statement_pool.rb
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb')
| -rw-r--r-- | activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb index c742799aab..31cf2b4dbf 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb @@ -76,12 +76,6 @@ module ActiveRecord true end - # Returns true, since this connection adapter supports prepared statement - # caching. - def supports_statement_cache? - true - end - def supports_index_sort_order? !mariadb? && version >= "8.0.1" end |