diff options
author | Xavier Noria <fxn@hashref.com> | 2012-03-01 16:15:00 -0800 |
---|---|---|
committer | Xavier Noria <fxn@hashref.com> | 2012-03-01 16:16:31 -0800 |
commit | bbe7dac2230c6c9410fda59f6b259d3e53ea437e (patch) | |
tree | bc65ca538f713d8165d21bfb8040e7d078873b12 /activerecord/lib/active_record/connection_adapters/abstract | |
parent | c2897901de4266e5c02da6cc5a9348bfde13552e (diff) | |
download | rails-bbe7dac2230c6c9410fda59f6b259d3e53ea437e.tar.gz rails-bbe7dac2230c6c9410fda59f6b259d3e53ea437e.tar.bz2 rails-bbe7dac2230c6c9410fda59f6b259d3e53ea437e.zip |
revert setting NOT NULL constraints in add_timestamps
Commit 3dbedd2 added NOT NULL constraints both to table
creation and modification. For creation the new default
makes sense, but the generic situation for changing a
table is that there exist records. Those records have
no creation or modification timestamps, and in the
general case you don't even know them, so when updating
a table these constraints are not going to work. See
a bug report for this use case in #3334.
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/abstract')
-rw-r--r-- | activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb index 1f6a94af34..a0e2900120 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb @@ -508,8 +508,8 @@ module ActiveRecord # ===== Examples # add_timestamps(:suppliers) def add_timestamps(table_name) - add_column table_name, :created_at, :datetime, :null => false - add_column table_name, :updated_at, :datetime, :null => false + add_column table_name, :created_at, :datetime + add_column table_name, :updated_at, :datetime end # Removes the timestamp columns (created_at and updated_at) from the table definition. |