aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters/abstract
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2013-08-09 11:16:12 -0700
committerRafael Mendonça França <rafaelmfranca@gmail.com>2013-08-09 11:16:12 -0700
commit4f5f59a492bd32afa476ac6b51ca5295b70fe246 (patch)
treea3ee3dfc6847b330803162ab320751c5e4f42b20 /activerecord/lib/active_record/connection_adapters/abstract
parent0053b2a1c497832da23f6dcb3ea628f3c8bb4d30 (diff)
parent5ef02de131d1d655f15673cbf5593589d97bf675 (diff)
downloadrails-4f5f59a492bd32afa476ac6b51ca5295b70fe246.tar.gz
rails-4f5f59a492bd32afa476ac6b51ca5295b70fe246.tar.bz2
rails-4f5f59a492bd32afa476ac6b51ca5295b70fe246.zip
Merge pull request #11820 from vipulnsward/remove_s2b
Remove redundant `string_to_binary` from type-casting
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/abstract')
-rw-r--r--activerecord/lib/active_record/connection_adapters/abstract/quoting.rb1
-rw-r--r--activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb3
2 files changed, 0 insertions, 4 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb b/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb
index d18b9c991f..c8fa4ef9af 100644
--- a/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb
@@ -15,7 +15,6 @@ module ActiveRecord
return "'#{quote_string(value)}'" unless column
case column.type
- when :binary then "'#{quote_string(column.string_to_binary(value))}'"
when :integer then value.to_i.to_s
when :float then value.to_f.to_s
else
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
index 0be4b5cb19..063b19871a 100644
--- a/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
@@ -16,9 +16,6 @@ module ActiveRecord
# +columns+ attribute of said TableDefinition object, in order to be used
# for generating a number of table creation or table changing SQL statements.
class ColumnDefinition < Struct.new(:name, :type, :limit, :precision, :scale, :default, :null, :first, :after, :primary_key) #:nodoc:
- def string_to_binary(value)
- value
- end
def primary_key?
primary_key || type.to_sym == :primary_key