diff options
author | Sean Griffin <sean@thoughtbot.com> | 2014-06-18 05:55:36 -0600 |
---|---|---|
committer | Sean Griffin <sean@thoughtbot.com> | 2014-06-18 06:20:18 -0600 |
commit | 0336efaae8f4942037a31652bce96d9e93eae0ae (patch) | |
tree | 854a82c77505d5691fe7246516fefd036610f207 /activerecord/lib/active_record/connection_adapters/abstract | |
parent | dccf6da66bf4a63971e1f12b98cb1bb1fe5a9015 (diff) | |
download | rails-0336efaae8f4942037a31652bce96d9e93eae0ae.tar.gz rails-0336efaae8f4942037a31652bce96d9e93eae0ae.tar.bz2 rails-0336efaae8f4942037a31652bce96d9e93eae0ae.zip |
Don't use column object for type casting in `quoting`
We're never going to be able to use the attribute object here, however,
so let's just accept the ugly demeter violation here for now.
Remove test cases which were either redundant with other tests in the
file, or were actually testing the type objects (which are tested
elsewhere)
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/abstract')
-rw-r--r-- | activerecord/lib/active_record/connection_adapters/abstract/quoting.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb b/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb index 04ae67234f..ff92375820 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb @@ -14,8 +14,8 @@ module ActiveRecord # value. Is this really the only case? Are we missing tests for other types? # We should have a real column object passed (or nil) here, and check for that # instead - if column.respond_to?(:type_cast_for_database) - value = column.type_cast_for_database(value) + if column.respond_to?(:cast_type) + value = column.cast_type.type_cast_for_database(value) end _quote(value) @@ -34,8 +34,8 @@ module ActiveRecord # value. Is this really the only case? Are we missing tests for other types? # We should have a real column object passed (or nil) here, and check for that # instead - if column.respond_to?(:type_cast_for_database) - value = column.type_cast_for_database(value) + if column.respond_to?(:cast_type) + value = column.cast_type.type_cast_for_database(value) end _type_cast(value) |