diff options
author | Ryuta Kamizono <kamipo@gmail.com> | 2017-06-29 16:25:32 +0900 |
---|---|---|
committer | Ryuta Kamizono <kamipo@gmail.com> | 2017-06-29 16:37:45 +0900 |
commit | abbc8351cd19f676476242bd6a0836b83dc3f0f0 (patch) | |
tree | 8699c83ce52515f5a4f0bf35dbd5ee0979bae77a /activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb | |
parent | 1e798ccb8ff83cc5a014d333e7a1e92e5d146c23 (diff) | |
download | rails-abbc8351cd19f676476242bd6a0836b83dc3f0f0.tar.gz rails-abbc8351cd19f676476242bd6a0836b83dc3f0f0.tar.bz2 rails-abbc8351cd19f676476242bd6a0836b83dc3f0f0.zip |
Should use the same connection in using query cache
`test_cache_is_available_when_using_a_not_connected_connection` is
always failed if running only the test since #29609.
```
% ARCONN=mysql2 be ruby -w -Itest test/cases/query_cache_test.rb -n test_cache_is_available_when_using_a_not_connected_connection
Using mysql2
Run options: -n test_cache_is_available_when_using_a_not_connected_connection --seed 15043
F
Finished in 0.070519s, 14.1806 runs/s, 28.3612 assertions/s.
1) Failure:
QueryCacheTest#test_cache_is_available_when_using_a_not_connected_connection [test/cases/query_cache_test.rb:336]:
2 instead of 1 queries were executed.
Queries:
SELECT `tasks`.* FROM `tasks` WHERE `tasks`.`id` = ? LIMIT ?
SET NAMES utf8 COLLATE utf8_unicode_ci, @@SESSION.sql_mode = CONCAT(CONCAT(@@sql_mode, ',STRICT_ALL_TABLES'), ',NO_AUTO_VALUE_ON_ZERO'), @@SESSION.sql_auto_is_null = 0, @@SESSION.wait_timeout = 2147483.
Expected: 1
Actual: 2
1 runs, 2 assertions, 1 failures, 0 errors, 0 skips
```
This failure is due to `LogSubscriber` will use not connected
`ActiveRecord::Base.connection` even if `Task.connection` is connected.
I fixed to always pass `type_casted_binds` to log subscriber to avoid
the issue.
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb')
0 files changed, 0 insertions, 0 deletions