diff options
| author | Sean Griffin <sean@thoughtbot.com> | 2014-11-18 15:19:15 -0800 |
|---|---|---|
| committer | Sean Griffin <sean@thoughtbot.com> | 2014-11-18 15:20:19 -0800 |
| commit | 08576b94ad4f19dfc368619d7751e211d23dcad8 (patch) | |
| tree | a8be0f668e65f0c90a79cd3031984c507225019c /activerecord/lib/active_record/attribute_set.rb | |
| parent | 78e7a0d3b7eaafe1ad0a45e3e355e1123cae3f8b (diff) | |
| download | rails-08576b94ad4f19dfc368619d7751e211d23dcad8.tar.gz rails-08576b94ad4f19dfc368619d7751e211d23dcad8.tar.bz2 rails-08576b94ad4f19dfc368619d7751e211d23dcad8.zip | |
Improve the performance of reading attributes
We added a comparison to "id", and call to `self.class.primary_key` a
*lot*. We also have performance hits from `&block` all over the place.
We skip the check in a new method, in order to avoid breaking the
behavior of `read_attribute`
Diffstat (limited to 'activerecord/lib/active_record/attribute_set.rb')
| -rw-r--r-- | activerecord/lib/active_record/attribute_set.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/attribute_set.rb b/activerecord/lib/active_record/attribute_set.rb index 21c58cbf1d..6b1d7ea79e 100644 --- a/activerecord/lib/active_record/attribute_set.rb +++ b/activerecord/lib/active_record/attribute_set.rb @@ -27,8 +27,8 @@ module ActiveRecord attributes.initialized_keys end - def fetch_value(name, &block) - self[name].value(&block) + def fetch_value(name) + self[name].value { |n| yield n if block_given? } end def write_from_database(name, value) |